Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: don't mutate user-provided configs (fixes #329) #330

Merged
merged 1 commit into from
Apr 4, 2017
Merged

Fix: don't mutate user-provided configs (fixes #329) #330

merged 1 commit into from
Apr 4, 2017

Conversation

not-an-aardvark
Copy link
Member

Previously, espree was adding impliedStrict: false to user-provided ecmaFeatures objects. This led to confusion and caused errors when using a frozen config. This commit updates the tokenize and parse functions to clone objects before mutating them.

This was referenced Apr 1, 2017
Merged
Closed
@not-an-aardvark not-an-aardvark merged commit 628cf3a into master Apr 4, 2017
@not-an-aardvark not-an-aardvark deleted the dont-mutate-config branch April 4, 2017 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platinumazure platinumazure platinumazure approved these changes

Assignees
No one assigned
Labels
accepted bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@not-an-aardvark @platinumazure